Ben Zheng <ben.zheng@reyosoft.com>: Author Summary
| Build | Completed | Code Changes | Tests |
|---|---|---|---|
| OFT › PHPDOC › #441 | 1 day ago | Testless build | |
| OFT › SNIFF › #343 | 1 day ago |
OFJ-1837 An error occurs when completed the incident workflow step
Add codes to make sure that an incident has not two workflow steps with the same cardinalities. OFJ-1840 It keeps loading on organization tree and system aggregation view page after run generate-systems.php
1. Add codes to use systemTypeId instead of hard-coded enum value. 2. Add codes to set aggregateSystemId. 3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname. OFJ-1835 Two Complete Step buttons show on the incident workflow tab view when the incidents are by generate-incidents.php
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table. |
Testless build |
| OFT › JSL › #659 | 1 day ago |
OFJ-1837 An error occurs when completed the incident workflow step
Add codes to make sure that an incident has not two workflow steps with the same cardinalities. OFJ-1840 It keeps loading on organization tree and system aggregation view page after run generate-systems.php
1. Add codes to use systemTypeId instead of hard-coded enum value. 2. Add codes to set aggregateSystemId. 3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname. OFJ-1835 Two Complete Step buttons show on the incident workflow tab view when the incidents are by generate-incidents.php
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table. |
55 passed |
| OFT › SCHEMA › #467 | 1 day ago |
OFJ-1837 An error occurs when completed the incident workflow step
Add codes to make sure that an incident has not two workflow steps with the same cardinalities. OFJ-1840 It keeps loading on organization tree and system aggregation view page after run generate-systems.php
1. Add codes to use systemTypeId instead of hard-coded enum value. 2. Add codes to set aggregateSystemId. 3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname. OFJ-1835 Two Complete Step buttons show on the incident workflow tab view when the incidents are by generate-incidents.php
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table. |
Testless build |
| TEST › TEST3 › #27 | 2 days ago |
OFJ-1831 A warning message shows with green background color when add an empty Actor
Change the codes to use Fisma.Util.message() instead. OFJ-1837 An error occurs when completed the incident workflow step
Add codes to make sure that an incident has not two workflow steps with the same cardinalities. OFJ-1840 It keeps loading on organization tree and system aggregation view page after run generate-systems.php
1. Add codes to use systemTypeId instead of hard-coded enum value. 2. Add codes to set aggregateSystemId. 3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname. OFJ-1776 Form overhaul
1. Add description attribute for threat_type element. 2. Add label element to onMouseEvent() for listening label as well. OFJ-1776 Form overhaul
1. Add buildDescription() method to Decorator for showing the description on above element. 2. Add showDescription() function to Util.js for showing description div when mouse over the element, hide the decription div when mouse out. 3. Add releted css style to main.css for showing description div. 4. Remove the property of 'background-color' and 'border' from the style of 'table.fisma_crud' from main.css. 5. Add the backgroung image for description div. OFJ-1835 Two Complete Step buttons show on the incident workflow tab view when the incidents are by generate-incidents.php
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table. OFJ-1776 Form overhaul
1. Change the background of description div from gray to white. 2. Change the font color of form from #404040 to white. |
Testless build |
| OFT › TRUNK › #1030 | 2 days ago |
OFJ-1837 An error occurs when completed the incident workflow step
Add codes to make sure that an incident has not two workflow steps with the same cardinalities. OFJ-1840 It keeps loading on organization tree and system aggregation view page after run generate-systems.php
1. Add codes to use systemTypeId instead of hard-coded enum value. 2. Add codes to set aggregateSystemId. 3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname. OFJ-1835 Two Complete Step buttons show on the incident workflow tab view when the incidents are by generate-incidents.php
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table. |
Testless build |
| TEST › TEST4 › #33 | 3 days ago |
OFJ-1831 A warning message shows with green background color when add an empty Actor
Change the codes to use Fisma.Util.message() instead. OFJ-1776 Form overhaul
1. Add description attribute for threat_type element. 2. Add label element to onMouseEvent() for listening label as well. OFJ-1776 Form overhaul
1. Add buildDescription() method to Decorator for showing the description on above element. 2. Add showDescription() function to Util.js for showing description div when mouse over the element, hide the decription div when mouse out. 3. Add releted css style to main.css for showing description div. 4. Remove the property of 'background-color' and 'border' from the style of 'table.fisma_crud' from main.css. 5. Add the backgroung image for description div. OFJ-1776 Form overhaul
1. Change the background of description div from gray to white. 2. Change the font color of form from #404040 to white. |
Testless build |
| OFT › PHPDOC › #436 | 6 days ago |
OFJ-1831 A warning message shows with green background color when add an empty Actor
Change the codes to use Fisma.Util.message() instead. OFJ-1776 Form overhaul
1. Add description attribute for threat_type element. 2. Add label element to onMouseEvent() for listening label as well. OFJ-1776 Form overhaul
1. Add buildDescription() method to Decorator for showing the description on above element. 2. Add showDescription() function to Util.js for showing description div when mouse over the element, hide the decription div when mouse out. 3. Add releted css style to main.css for showing description div. 4. Remove the property of 'background-color' and 'border' from the style of 'table.fisma_crud' from main.css. 5. Add the backgroung image for description div. OFJ-1809 Add Task as a behavior
1. Add Fisma_Doctrine_Behavior_HasTasks class to provides task behavior on model instances. 2. Add Fisma_Doctrine_Behavior_HasTasks_Generator class to generate the task behavior. 3. Add Fisma_Doctrine_Behavior_HasTasks_Proxy class to provide the proxy for the task generator. OFJ-1776 Form overhaul
1. Change the background of description div from gray to white. 2. Change the font color of form from #404040 to white. |
Testless build |
| OFT › SNIFF › #338 | 6 days ago |
OFJ-1831 A warning message shows with green background color when add an empty Actor
Change the codes to use Fisma.Util.message() instead. OFJ-1776 Form overhaul
1. Add description attribute for threat_type element. 2. Add label element to onMouseEvent() for listening label as well. OFJ-1776 Form overhaul
1. Add buildDescription() method to Decorator for showing the description on above element. 2. Add showDescription() function to Util.js for showing description div when mouse over the element, hide the decription div when mouse out. 3. Add releted css style to main.css for showing description div. 4. Remove the property of 'background-color' and 'border' from the style of 'table.fisma_crud' from main.css. 5. Add the backgroung image for description div. OFJ-1809 Add Task as a behavior
1. Add Fisma_Doctrine_Behavior_HasTasks class to provides task behavior on model instances. 2. Add Fisma_Doctrine_Behavior_HasTasks_Generator class to generate the task behavior. 3. Add Fisma_Doctrine_Behavior_HasTasks_Proxy class to provide the proxy for the task generator. OFJ-1776 Form overhaul
1. Change the background of description div from gray to white. 2. Change the font color of form from #404040 to white. |
Testless build |
| OFT › SCHEMA › #462 | 6 days ago |
OFJ-1831 A warning message shows with green background color when add an empty Actor
Change the codes to use Fisma.Util.message() instead. OFJ-1776 Form overhaul
1. Add description attribute for threat_type element. 2. Add label element to onMouseEvent() for listening label as well. OFJ-1776 Form overhaul
1. Add buildDescription() method to Decorator for showing the description on above element. 2. Add showDescription() function to Util.js for showing description div when mouse over the element, hide the decription div when mouse out. 3. Add releted css style to main.css for showing description div. 4. Remove the property of 'background-color' and 'border' from the style of 'table.fisma_crud' from main.css. 5. Add the backgroung image for description div. OFJ-1809 Add Task as a behavior
1. Add Fisma_Doctrine_Behavior_HasTasks class to provides task behavior on model instances. 2. Add Fisma_Doctrine_Behavior_HasTasks_Generator class to generate the task behavior. 3. Add Fisma_Doctrine_Behavior_HasTasks_Proxy class to provide the proxy for the task generator. OFJ-1776 Form overhaul
1. Change the background of description div from gray to white. 2. Change the font color of form from #404040 to white. |
Testless build |
| Build | Completed | Code Changes | Tests |
|---|---|---|---|
| OFT › JSL › #649 | 1 week ago | 1 of 55 failed | |
| TEST › TEST3 › #10 | 3 months ago |
OFJ-1325 Migrate doctine-cli script to subclass Fisma_Cli
1. Fix some defects from OFC-483. 2. Change the descriptions to "Automatically pick yes/no for yes/no questions". 3. Add the codes to Fisma_Cli_Doctrine to make sure the user doesn't use both argument at the same time. 4. Update _getTaskClassFromArgs() function in Fisma_Doctrine_Cli to call Fisma_Doctrine_Task_$taskname. 5. Add class Fisma_Doctrine_Task_BuildAllLoad extends Doctrine_Task_BuildAllLoad. 6. Add class Fisma_Doctrine_Task_RebuildDb extends Doctrine_Task_RebuildDb. 7. Add class Fisma_Doctrine_Task_DropDb extends Doctrine_Task_DropDb. OFJ-1585 Remove generated models in doctrine-cli.php
1. Add class Fisma_Doctrine_Task_BuildAll extends Doctrine_Task_BuildAll. 2. Add class Fisma_Doctrine_Task_BuildAllLoad extends Doctrine_Task_BuildAllLoad. 3. Add class Fisma_Doctrine_Task_GenerateModelsYaml extends Doctrine_Task_GenerateModelsYaml. 4. Update getTaskClassFromArgs() function to return Fisma_Doctrine_Task_$taskname in Fisma_Doctrine_Cli. 5. Update _construct() function to call Fisma_Doctrine_Task_BuildAll in Fisma_Doctrine_Task_RebuildDb. OFJ-1600 Remove fisma.js from project
1. Change the filename "fisma.js" to "Fisma.js". 2. Move message() from fisma.js to Util.js, and update message() to Fisma.Util.message() through openfisma. 3. Move updateTimeField() from fisma.js to Util.js and update Fisma_Zend_Form_Element_Time class where reference it. 4. Move the ZfDebugYuiLogging codes from fisma.js to ZfDebugYuiLogging.js. 5. Move callCalendar() and showCalendar() from fisma.js to Calendar.js. 6. Remove the rest functions which are not used any more from Fisma.js. 7. Update InjectAsset view help and update build.xml. OFJ-1638 Role nickname of "IV&V" shows incorrectly at the Privilege row on the view-matrix page when use IE7
Add the code to escape the column label of YUI datatable. OFJ-1615 The table's border does not show at FIPS-199 tab view on system page and incident detail page
Set only the border of first level child 'td' to boder:none. OFJ-1641 Change 'Contains' to 'Contains Words' and 'Does Not Contain' to 'Does Not Contain Words'
Update the words in CriteriaDefinition.js file OFJ-298 Login fails when username is same as its assigned role's nickname
1. Add prefix 'role_' and 'user_' string to the Zend_Acl role object and user object in User model. 2. Add prefix 'user_' for 'root' user in Fisma_Zend_Acl. 3. Change 'root' to 'user_root' for relating unit test. OFJ-1585 Remove generated models in doctrine-cli.php
1. Update the UI for doctrine.php. 2. Add specify doctrine tasks to getArgumentsDefinitions() in doctrine.php. 3. Add _getAvailableDoctrineTaskFromArguments() to get the task name from arguments and throw exception if there is no or more than one options. 4. Remove the block migration codes. 5. Update Fisma_Doctrine_Cli unit test. OFJ-1585 Remove generated models in doctrine-cli.php
Remove 'Fisma_Doctrine_Task_' instead of 'Doctrine_Task_' in construct function so that the taskname can be displayed correctly. OFJ-1325 Migrate doctine-cli script to subclass Fisma_Cli
1. Move try/catch block from doctrine-cli.php to Fisma_Cli_Abstract class. 2. Move the bootstrap resource 'registerLogger' from doctrine-cli.php to scripts/bin/bootstrap.php file. OFJ-1325 Migrate doctine-cli script to subclass Fisma_Cli
1. Move all logic from script/bin/doctrine-cli.php to _run() function in Fisma_Cli_Doctrine. 2. Create a new instance of Fisma_Cli_Doctrine class and call run() when run the script. 3. Add the codes to block 'migrate' action in in Fisma_Cli_DoctrineCli class. 4. Override the getLoadedTasks() function at Fisma_Doctrine_Cli to remove 'migrate' task message from CLI. OFJ-1625 It should change 'Fisma_Exception' to 'Fisma_Zend_Exception_User' in CLI scripts because 'Fisma_Exception' does not exist
Change 'Fisma_Exception' to Fisma_Zend_Exception_User' in CLI scripts. OFJ-1585 Remove generated models in doctrine-cli.php
1. Add static function getDoctrineTaskName() to Fisma_Doctrine_Task. 2. Change codes to Fisma_Doctrine_Task::getDoctrineTaskName() through the task classes. OFJ-1615 The table's border does not show at FIPS-199 tab view on system page and incident detail page
Add missing table selector from previous commit. OFJ-1433 When print dashboard to PDF, the graphs breaks into two pieces between pages
Change id selector to jqplot-threat-legend class. OFJ-1622 The drop down list on asset create page looks different between IE7 and Firefox
Remove the codes from form which sets the fixed width for drop down list. OFJ-1625 It should change 'Fisma_Exception' to 'Fisma_Zend_Exception_User' in CLI scripts because 'Fisma_Exception' does not exist
Fix the error in migration version 127. OFJ-1626 An error occurs on overdue findings report page when there is no sample data
Set reportData to empty array if there is no organizations. Merge remote branch 'origin/master' into ofj1585
Conflicts: tests/library/Fisma/Doctrine/Cli.php OFJ-1433 When print dashboard to PDF, the graphs breaks into two pieces between pages
1. Add css to set the page-breaking behavior to the chartContainer. 2. Add css to display legend of jqplot. 3. Add css to hide expand and collapse button on the tree. 4. Add css to display chart of system dashboard. OFJ-1585 Remove generated models in doctrine-cli.php
1. Remove dump-data, load-data and build-all tasks. 2. Add sample-data|s to getArgumentsDefinitions() function. OFJ-1619 No successful or warning message shows when test e-mail configuration on E-mail configuration page under product mode
Remove the code which initializes the style of message box to 'display:none'. OFJ-1585 Remove generated models in doctrine-cli.php
Change the message to 'database dropping cancelled'. OFJ-1626 An error occurs on overdue findings report page when there is no sample data
1. Add the codes to check $organizations is empty or not, If yes, do not add whereIn() to the query. 2. Add codes to display a warning message if there is no organizations in openfisma. OFJ-1325 Migrate doctine-cli script to subclass Fisma_Cli
Use unset() function to remove migrate action from the tasks array instead of just set its null. |
Testless build |
| OFT › PHPDOC › #267 | 5 months ago |
OFJ-1596 The finding summary page does not look right when there is overdue finding
Set the style of marginBottom of inner table to 0px. OFJ-1598 The tree structure is broken on finding summary page view by system aggregation after move a system into disposal system
1. Add the codes to skip all the child systems of disposal systems while prepare tree structure. 2. Add the codes to sort the parent node when move child system of disposal systems to parent node. |
Testless build |
| OFT › SCHEMA › #294 | 5 months ago |
OFJ-1596 The finding summary page does not look right when there is overdue finding
Set the style of marginBottom of inner table to 0px. OFJ-1598 The tree structure is broken on finding summary page view by system aggregation after move a system into disposal system
1. Add the codes to skip all the child systems of disposal systems while prepare tree structure. 2. Add the codes to sort the parent node when move child system of disposal systems to parent node. |
Testless build |
| Build | Completed | Code Changes | Tests |
|---|---|---|---|
| TEST › TEST3 › #27 | 2 days ago |
OFJ-1831 A warning message shows with green background color when add an empty Actor
Change the codes to use Fisma.Util.message() instead. OFJ-1837 An error occurs when completed the incident workflow step
Add codes to make sure that an incident has not two workflow steps with the same cardinalities. OFJ-1840 It keeps loading on organization tree and system aggregation view page after run generate-systems.php
1. Add codes to use systemTypeId instead of hard-coded enum value. 2. Add codes to set aggregateSystemId. 3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname. OFJ-1776 Form overhaul
1. Add description attribute for threat_type element. 2. Add label element to onMouseEvent() for listening label as well. OFJ-1776 Form overhaul
1. Add buildDescription() method to Decorator for showing the description on above element. 2. Add showDescription() function to Util.js for showing description div when mouse over the element, hide the decription div when mouse out. 3. Add releted css style to main.css for showing description div. 4. Remove the property of 'background-color' and 'border' from the style of 'table.fisma_crud' from main.css. 5. Add the backgroung image for description div. OFJ-1835 Two Complete Step buttons show on the incident workflow tab view when the incidents are by generate-incidents.php
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table. OFJ-1776 Form overhaul
1. Change the background of description div from gray to white. 2. Change the font color of form from #404040 to white. |
Testless build |
| TEST › TEST2 › #2 | 3 months ago |
OFJ-1600 Remove fisma.js from project
1. Change the filename "fisma.js" to "Fisma.js". 2. Move message() from fisma.js to Util.js, and update message() to Fisma.Util.message() through openfisma. 3. Move updateTimeField() from fisma.js to Util.js and update Fisma_Zend_Form_Element_Time class where reference it. 4. Move the ZfDebugYuiLogging codes from fisma.js to ZfDebugYuiLogging.js. 5. Move callCalendar() and showCalendar() from fisma.js to Calendar.js. 6. Remove the rest functions which are not used any more from Fisma.js. 7. Update InjectAsset view help and update build.xml. OFJ-1657 The year selection is not shown on date pickup panel when click the Discovered Date icon on the create new finding page with IE7
1. Change z-index 99 to 1000 in addCalendarPopupToTextField() function. 2. Remove redundant codes. OFJ-1585 Remove generated models in doctrine-cli.php
1. Add static function getDoctrineTaskName() to Fisma_Doctrine_Task. 2. Change codes to Fisma_Doctrine_Task::getDoctrineTaskName() through the task classes. OFJ-1433 When print dashboard to PDF, the graphs breaks into two pieces between pages
Change id selector to jqplot-threat-legend class. Merge remote branch 'origin/master' into ofj1585
Conflicts: tests/library/Fisma/Doctrine/Cli.php OFJ-1585 Remove generated models in doctrine-cli.php
Change the message to 'database dropping cancelled'. |
Testless build |
Add codes to make sure that an incident has not two workflow steps with the same cardinalities.
1. Add codes to use systemTypeId instead of hard-coded enum value.
2. Add codes to set aggregateSystemId.
3. Fix a bug which has a lot of white space at the beginning and end of system name and nickname.
Change the variable of $this to $completedStep so that the workflow completed step can be saved to table.