Dale_Frey: Author Summary

OFJ-920 An error appears when click the "null" link on pending finding page The Approve Pending Findings page needed to be removed as it no longer has any use - OFJ-920?focusedCommentId=13493#action_13493">http://jira.openfisma.org/browse/OFJ-920?focusedCommentId=13493#action_13493 Removed link, deleted the view, and removed the associated function from the index controller Edited: application/modules/finding/controllers/IndexController.php Edited: library/Fisma/Menu.php Deleted: application/modules/finding/views/scripts/index/approve.phtml (version 0ef5ea9f2ab2d41fff2846a31cf4dd768fab55b8)

OFJ-920 An error appears when click the "null" link on pending finding page The Approve Pending Findings page needed to be removed as it no longer has any use - OFJ-920?focusedCommentId=13493#action_13493">http://jira.openfisma.org/browse/OFJ-920?focusedCommentId=13493#action_13493 Removed link, deleted the view, and removed the associated function from the index controller Edited: application/modules/finding/controllers/IndexController.php Edited: library/Fisma/Menu.php Deleted: application/modules/finding/views/scripts/index/approve.phtml (version 0ef5ea9f2ab2d41fff2846a31cf4dd768fab55b8)

OFJ-952 Exception thrown when trying to create a vulnerability Removed the Add Vulnerability button from the vulnerabilities search page. Edited: application/modules/vm/views/scripts/vulnerability/searchbox.phtml (version 00698b03582e6a34a9048252ce8b74cee00db01e)

OFJ-952 Exception thrown when trying to create a vulnerability Removed the Add Vulnerability button from the vulnerabilities search page. Edited: application/modules/vm/views/scripts/vulnerability/searchbox.phtml (version 00698b03582e6a34a9048252ce8b74cee00db01e)

OFJ-995 An error occurs when goes to System Inventory=> Administration =>Products page Removed the sub menu for SystemInventory>Admin>Products as we already have a menu for that page in the VM now under Vulnerabilities>Admin>Products Edited: library/Fisma/Menu.php (version 4c5e9855f9b2644c35ab57f2ee70afc309c5ab92)

OFJ-995 An error occurs when goes to System Inventory=> Administration =>Products page Removed the sub menu for SystemInventory>Admin>Products as we already have a menu for that page in the VM now under Vulnerabilities>Admin>Products Edited: library/Fisma/Menu.php (version 4c5e9855f9b2644c35ab57f2ee70afc309c5ab92)

OFJ-949 Menu UI for Documentation Types is not sorted correctly Sorted the submenus of Reports and Administration in SysInventory alphabetically Edited: library/Fisma/Menu.php (version 63003ac150d824c1beff1c6a0c9714a0a573f440)

OFJ-949 Menu UI for Documentation Types is not sorted correctly Sorted the submenus of Reports and Administration in SysInventory alphabetically Edited: library/Fisma/Menu.php (version 63003ac150d824c1beff1c6a0c9714a0a573f440)

OFJ-943 Vulnerability Management Cleanup Replace table formatting with div formatting as requested in http://crucible.openfisma.org/cru/OFC-125#c1138 Edited: vulnerability.phtml (version 4382bfe14723b93fbfea07e9a47d982edc19ebe7)

OFJ-943 Vulnerability Management Cleanup Edited: Local.php Removed commented code and changed Array() to array() as requested in http://crucible.openfisma.org/cru/OFC-125#c1131 Edited: VulnerabilityReportController.php Added spacing between paramiters in addColumn() call as requested in http://crucible.openfisma.org/cru/OFC-125#c1135 Edited: Column.php Updated phpdoc as requested in http://crucible.openfisma.org/cru/OFC-125#c1137 (version d8efa4409e96de24afbb626185cb6e3f9c40797a)

(OFJ-943 part 5) Reported Issue: "On Upload Scan Results page, the '*Network:' list needs to be sorted alphabetically. Edited: application/modules/vm/controllers/VulnerabilityController.php Fix: The network array is run through asort() before being sent to the client-browser. (version 3f88786cb741922919c96ed743664d856ee49712)

OFJ-943 Vulnerability Management Cleanup Replaced table formatting with div formatting in finding.phtml as requested in http://crucible.openfisma.org/cru/OFC-125#c1140 And also indented the code within the new div tags. (version 013f530645e34351226b093c7a7d18af2e0ae9f0)

(OFJ-943 part 1) Issue Claimed: "The finding details screen now has wasted horizontal space (after removing the asset tab). It would be good to reclaim this space" Edited: application/modules/finding/views/scripts/remediation/finding.phtml Fix: Have edited the finding details page to move the Description box to the right of the Details box. (version 0ad46941fe40b3676ed84ceeb216fbbb6856b88c)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 7) Reported Issue: When a vulnerability is reopened, the message says 1 vulnerabilities *need* reopened", it should say were instead of need. (Pedantic comment: it should actually say 1 vulnerability *was* created", or "2 vulnerabilities *were* created", etc.) Edited: application/modules/vm/controllers/VulnerabilityController.php Fix: The VulnerabilityController now watched how many vulnerabilities were created/suppressed/etc, and uses the words of were/was correctly. (version 52b3d9773aa88d47a33d73cebd2d7893b2b35d6d)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 6) Reported Issue: "Finding menu still has a Upload Scan Results button. Remove it" Edited: library/Fisma/Menu.php Fix: Removed the Upload Scan Results button from the Findings tab. (version cf9fb50061a011a47380912f5ac912c29956ae10)

OFJ-943 Vulnerability Management Cleanup Replaced a empty() with a isset() to check if a variable has been declared. This is a fix for http://crucible.openfisma.org/cru/OFC-125#c1134 (version 9dbc469ec73e98505da09b3c64259ab761e88e79)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 2) Reported Issue: "Lots of warnings/notices upload Scan Results" Edited: library/Fisma/Inject/Abstract.php Fix: The counter which counts how many vulnerabilities were suppressed may not be initalized. Implemented an a line to check, and init the counter to 0 when needed. Edited: library/Fisma/Inject/Factory.php Fix: According to Andrew, the $data['system'] and $data['findingSource'] are no longer needed, and no longer used. Removing them from usage to prevent needless warnings and error messages. Edited: library/Fisma/Inject/Nessus.php Fix: Initalizes the ip variable to null for the event where ip is not given for a new Asset. Accordning to Andrew and the older git branches, Assets name in the past may sometimes be blank or just be a port number. Init'ing the ip var to null will remove needless warnings and error messages. (version deeb7bdb15e42debe70d986b7e17f8e8e05ccf60)

OFJ-943 Vulnerability Management Cleanup Removed commented line of code at http://crucible.openfisma.org/cru/OFC-125#c1129 Changed param call count for the Fisma_Inject_Abstract class and changed the param count in the constructor of that class as needed in; http://crucible.openfisma.org/cru/OFC-125#c1129 Edited: library/Fisma/Inject/Abstract.php Edited: library/Fisma/Inject/Factory.php (version 2998a3c0043b60897846c21d506aa638be5c6e45)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 8) Reported Issue: "All report columns which have numeric values should use the numeric format option, otherwise they dont sort correctly" (in Vuln.>Reports>Vuln.Services) Edited: application/modules/vm/controllers/VulnerabilityReportController.php Fix: use of "new Fisma_Report_Column(~" now uses the additional paramiters created in this commit, to state that the given col. is a number and not a string (states the parser for YUI-datatable to use). Edited: library/Fisma/Report/Column.php and: library/Fisma/Yui/DataTable/Column.php Fix: Added vars and getter functions into these classes for parser support. Edited: library/Fisma/Yui/DataTable/Local.php Fix: Edited getYuiResponseSchema() read the parser information of column classes, and return data accordingly. Edited: library/Fisma/Zend/Controller/Action/Helper/ReportContextSwitch.php Fix: Because the Fisma/Report/Column.php class and Fisma/Yui/DataTable/Column.php class has information moved from one to the other by ReportContextSwitch.php, and update had to be done to make sure the parser information was carried over. (version d07a5ed75f75ae340e66bd37acc1913627a066b7)

(OFJ-943 part 4) Reported Issue: "Same thing as #1 except for vulnerability details page. (vm4.png)" ((wasted horizontal space (after removing the asset tab). It would be good to reclaim this space. Either add a new table to the right of the existing table)) Editted: application/modules/vm/views/scripts/vulnerability/vulnerability.phtml Fix: Added in html table blocks to move the Description box to the right of the Details box on the vulnerability details page. (version 081e0fac261a6f63a797ba8c851dcf3e72f5726b)

OFJ-943 Vulnerability Management Cleanup Replace table formatting with div formatting as requested in http://crucible.openfisma.org/cru/OFC-125#c1138 Edited: vulnerability.phtml (version 4382bfe14723b93fbfea07e9a47d982edc19ebe7)

OFJ-943 Vulnerability Management Cleanup Edited: Local.php Removed commented code and changed Array() to array() as requested in http://crucible.openfisma.org/cru/OFC-125#c1131 Edited: VulnerabilityReportController.php Added spacing between paramiters in addColumn() call as requested in http://crucible.openfisma.org/cru/OFC-125#c1135 Edited: Column.php Updated phpdoc as requested in http://crucible.openfisma.org/cru/OFC-125#c1137 (version d8efa4409e96de24afbb626185cb6e3f9c40797a)

(OFJ-943 part 5) Reported Issue: "On Upload Scan Results page, the '*Network:' list needs to be sorted alphabetically. Edited: application/modules/vm/controllers/VulnerabilityController.php Fix: The network array is run through asort() before being sent to the client-browser. (version 3f88786cb741922919c96ed743664d856ee49712)

OFJ-943 Vulnerability Management Cleanup Replaced table formatting with div formatting in finding.phtml as requested in http://crucible.openfisma.org/cru/OFC-125#c1140 And also indented the code within the new div tags. (version 013f530645e34351226b093c7a7d18af2e0ae9f0)

(OFJ-943 part 1) Issue Claimed: "The finding details screen now has wasted horizontal space (after removing the asset tab). It would be good to reclaim this space" Edited: application/modules/finding/views/scripts/remediation/finding.phtml Fix: Have edited the finding details page to move the Description box to the right of the Details box. (version 0ad46941fe40b3676ed84ceeb216fbbb6856b88c)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 7) Reported Issue: When a vulnerability is reopened, the message says 1 vulnerabilities *need* reopened", it should say were instead of need. (Pedantic comment: it should actually say 1 vulnerability *was* created", or "2 vulnerabilities *were* created", etc.) Edited: application/modules/vm/controllers/VulnerabilityController.php Fix: The VulnerabilityController now watched how many vulnerabilities were created/suppressed/etc, and uses the words of were/was correctly. (version 52b3d9773aa88d47a33d73cebd2d7893b2b35d6d)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 6) Reported Issue: "Finding menu still has a Upload Scan Results button. Remove it" Edited: library/Fisma/Menu.php Fix: Removed the Upload Scan Results button from the Findings tab. (version cf9fb50061a011a47380912f5ac912c29956ae10)

OFJ-943 Vulnerability Management Cleanup Replaced a empty() with a isset() to check if a variable has been declared. This is a fix for http://crucible.openfisma.org/cru/OFC-125#c1134 (version 9dbc469ec73e98505da09b3c64259ab761e88e79)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 2) Reported Issue: "Lots of warnings/notices upload Scan Results" Edited: library/Fisma/Inject/Abstract.php Fix: The counter which counts how many vulnerabilities were suppressed may not be initalized. Implemented an a line to check, and init the counter to 0 when needed. Edited: library/Fisma/Inject/Factory.php Fix: According to Andrew, the $data['system'] and $data['findingSource'] are no longer needed, and no longer used. Removing them from usage to prevent needless warnings and error messages. Edited: library/Fisma/Inject/Nessus.php Fix: Initalizes the ip variable to null for the event where ip is not given for a new Asset. Accordning to Andrew and the older git branches, Assets name in the past may sometimes be blank or just be a port number. Init'ing the ip var to null will remove needless warnings and error messages. (version deeb7bdb15e42debe70d986b7e17f8e8e05ccf60)

OFJ-943 Vulnerability Management Cleanup Removed commented line of code at http://crucible.openfisma.org/cru/OFC-125#c1129 Changed param call count for the Fisma_Inject_Abstract class and changed the param count in the constructor of that class as needed in; http://crucible.openfisma.org/cru/OFC-125#c1129 Edited: library/Fisma/Inject/Abstract.php Edited: library/Fisma/Inject/Factory.php (version 2998a3c0043b60897846c21d506aa638be5c6e45)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 8) Reported Issue: "All report columns which have numeric values should use the numeric format option, otherwise they dont sort correctly" (in Vuln.>Reports>Vuln.Services) Edited: application/modules/vm/controllers/VulnerabilityReportController.php Fix: use of "new Fisma_Report_Column(~" now uses the additional paramiters created in this commit, to state that the given col. is a number and not a string (states the parser for YUI-datatable to use). Edited: library/Fisma/Report/Column.php and: library/Fisma/Yui/DataTable/Column.php Fix: Added vars and getter functions into these classes for parser support. Edited: library/Fisma/Yui/DataTable/Local.php Fix: Edited getYuiResponseSchema() read the parser information of column classes, and return data accordingly. Edited: library/Fisma/Zend/Controller/Action/Helper/ReportContextSwitch.php Fix: Because the Fisma/Report/Column.php class and Fisma/Yui/DataTable/Column.php class has information moved from one to the other by ReportContextSwitch.php, and update had to be done to make sure the parser information was carried over. (version d07a5ed75f75ae340e66bd37acc1913627a066b7)

(OFJ-943 part 4) Reported Issue: "Same thing as #1 except for vulnerability details page. (vm4.png)" ((wasted horizontal space (after removing the asset tab). It would be good to reclaim this space. Either add a new table to the right of the existing table)) Editted: application/modules/vm/views/scripts/vulnerability/vulnerability.phtml Fix: Added in html table blocks to move the Description box to the right of the Details box on the vulnerability details page. (version 081e0fac261a6f63a797ba8c851dcf3e72f5726b)

OFJ-943 Vulnerability Management Cleanup Replace table formatting with div formatting as requested in http://crucible.openfisma.org/cru/OFC-125#c1138 Edited: vulnerability.phtml (version 4382bfe14723b93fbfea07e9a47d982edc19ebe7)

OFJ-943 Vulnerability Management Cleanup Edited: Local.php Removed commented code and changed Array() to array() as requested in http://crucible.openfisma.org/cru/OFC-125#c1131 Edited: VulnerabilityReportController.php Added spacing between paramiters in addColumn() call as requested in http://crucible.openfisma.org/cru/OFC-125#c1135 Edited: Column.php Updated phpdoc as requested in http://crucible.openfisma.org/cru/OFC-125#c1137 (version d8efa4409e96de24afbb626185cb6e3f9c40797a)

(OFJ-943 part 5) Reported Issue: "On Upload Scan Results page, the '*Network:' list needs to be sorted alphabetically. Edited: application/modules/vm/controllers/VulnerabilityController.php Fix: The network array is run through asort() before being sent to the client-browser. (version 3f88786cb741922919c96ed743664d856ee49712)

OFJ-943 Vulnerability Management Cleanup Replaced table formatting with div formatting in finding.phtml as requested in http://crucible.openfisma.org/cru/OFC-125#c1140 And also indented the code within the new div tags. (version 013f530645e34351226b093c7a7d18af2e0ae9f0)

(OFJ-943 part 1) Issue Claimed: "The finding details screen now has wasted horizontal space (after removing the asset tab). It would be good to reclaim this space" Edited: application/modules/finding/views/scripts/remediation/finding.phtml Fix: Have edited the finding details page to move the Description box to the right of the Details box. (version 0ad46941fe40b3676ed84ceeb216fbbb6856b88c)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 7) Reported Issue: When a vulnerability is reopened, the message says 1 vulnerabilities *need* reopened", it should say were instead of need. (Pedantic comment: it should actually say 1 vulnerability *was* created", or "2 vulnerabilities *were* created", etc.) Edited: application/modules/vm/controllers/VulnerabilityController.php Fix: The VulnerabilityController now watched how many vulnerabilities were created/suppressed/etc, and uses the words of were/was correctly. (version 52b3d9773aa88d47a33d73cebd2d7893b2b35d6d)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 6) Reported Issue: "Finding menu still has a Upload Scan Results button. Remove it" Edited: library/Fisma/Menu.php Fix: Removed the Upload Scan Results button from the Findings tab. (version cf9fb50061a011a47380912f5ac912c29956ae10)

OFJ-943 Vulnerability Management Cleanup Replaced a empty() with a isset() to check if a variable has been declared. This is a fix for http://crucible.openfisma.org/cru/OFC-125#c1134 (version 9dbc469ec73e98505da09b3c64259ab761e88e79)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 2) Reported Issue: "Lots of warnings/notices upload Scan Results" Edited: library/Fisma/Inject/Abstract.php Fix: The counter which counts how many vulnerabilities were suppressed may not be initalized. Implemented an a line to check, and init the counter to 0 when needed. Edited: library/Fisma/Inject/Factory.php Fix: According to Andrew, the $data['system'] and $data['findingSource'] are no longer needed, and no longer used. Removing them from usage to prevent needless warnings and error messages. Edited: library/Fisma/Inject/Nessus.php Fix: Initalizes the ip variable to null for the event where ip is not given for a new Asset. Accordning to Andrew and the older git branches, Assets name in the past may sometimes be blank or just be a port number. Init'ing the ip var to null will remove needless warnings and error messages. (version deeb7bdb15e42debe70d986b7e17f8e8e05ccf60)

OFJ-943 Vulnerability Management Cleanup Removed commented line of code at http://crucible.openfisma.org/cru/OFC-125#c1129 Changed param call count for the Fisma_Inject_Abstract class and changed the param count in the constructor of that class as needed in; http://crucible.openfisma.org/cru/OFC-125#c1129 Edited: library/Fisma/Inject/Abstract.php Edited: library/Fisma/Inject/Factory.php (version 2998a3c0043b60897846c21d506aa638be5c6e45)

OFJ-943 Vulnerability Management Cleanup (OFJ-943 part 8) Reported Issue: "All report columns which have numeric values should use the numeric format option, otherwise they dont sort correctly" (in Vuln.>Reports>Vuln.Services) Edited: application/modules/vm/controllers/VulnerabilityReportController.php Fix: use of "new Fisma_Report_Column(~" now uses the additional paramiters created in this commit, to state that the given col. is a number and not a string (states the parser for YUI-datatable to use). Edited: library/Fisma/Report/Column.php and: library/Fisma/Yui/DataTable/Column.php Fix: Added vars and getter functions into these classes for parser support. Edited: library/Fisma/Yui/DataTable/Local.php Fix: Edited getYuiResponseSchema() read the parser information of column classes, and return data accordingly. Edited: library/Fisma/Zend/Controller/Action/Helper/ReportContextSwitch.php Fix: Because the Fisma/Report/Column.php class and Fisma/Yui/DataTable/Column.php class has information moved from one to the other by ReportContextSwitch.php, and update had to be done to make sure the parser information was carried over. (version d07a5ed75f75ae340e66bd37acc1913627a066b7)

(OFJ-943 part 4) Reported Issue: "Same thing as #1 except for vulnerability details page. (vm4.png)" ((wasted horizontal space (after removing the asset tab). It would be good to reclaim this space. Either add a new table to the right of the existing table)) Editted: application/modules/vm/views/scripts/vulnerability/vulnerability.phtml Fix: Added in html table blocks to move the Description box to the right of the Details box on the vulnerability details page. (version 081e0fac261a6f63a797ba8c851dcf3e72f5726b)