Mark ma <mark.ma@reyosoft.com>: Author Summary

Builds triggered by Mark ma <mark.ma@reyosoft.com>

Builds triggered by an author are those builds which contains changes committed by the author.
168
38 (23%)
130 (77%)

Breakages and Fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
4 (2% of all builds triggered)
1 (1% of all builds triggered)
-3
Build Completed Code Changes Tests
TEST › TEST3 › #25 1 week ago
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1808 Add POC column to Finding Injection Template

1. Add a column to finding upload template.
2. Add the codes to set pocId to finding.
Testless build
TEST › TEST4 › #31 1 week ago
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix the image loader bug on the first page of the panel.
2. Make panel background white.
3. Fix the text problem at the bottom left.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Do not concate WhatsNew.css into combined.css
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Delete sample files.
2. Add some exceptions to WhatsNewController.php
OFJ-1542 Refactor Fisma_FileSystem to make it testable

1. Add vfsStream library to tests.
2. Add tests/library/Fisma/FileSystem.php
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Move the javascript codes in WhatsNew layout to Fisma.WhatsNew
OFJ-1542 Refactor Fisma_FileSystem to make it testable

Example.php is not needed
OFJ-1543 Refactor Fisma_Menu to make it testable

Fix several bugs in Menu.php and Menu.yml
OFJ-1543 Refactor Fisma_Menu to make it testable

1. Fix the bug that User preferences is missing after auth type is set to ldap
OFJ-1777 Add administrator toggle for threat level vs residual risk as shown in default search view

1. Set the initiallyVisible of searchable fields of threatLevel and residualRisk based on the configuration of threat_type.
OFJ-1542 Refactor Fisma_FileSystem to make it testable

1. Do not need Example.php
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add whats-new.phtml layout.
Add WhatsNewController.php to get all the config files of new features and use whats-new layout to render.
Add index.phtml which is the template of whatsnew page.
Add showWhatsNewDialog() function to popup a new panel containing an iframe where what's page shows.
Add codes to call Fisma.Util.showWhatsNewDialog() in application/modules/default/views/scripts/dashboard/index.phtml.
Add jquery-localscroll.js plugin to public/javascripts/ folder.
Add jquery-scrollTo.js plugin to public/javascripts/ folder.
Add jquery-serialScroll.js plugin to public/javascripts/ folder.
Add whatsNew.css to public/stylesheets/ folder.
Add 'What's new' menu item under "user preference" menu.
Add codes to DashboardController.php to check whether it should show whatsnew panel.
Add swfobject.js for playing youtube video.
OFJ-1543 Refactor Fisma_Menu to make it testable

1. Fix a bug that Finding and System Inventory menu are not shown if there is no org/system
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Remove the codes to get current version from foot. Use DashboardController.php to pass current version instead.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Remove window format of carriage return.
OFJ-1543 Refactor Fisma_Menu to make it testable

1. Add application/config/menu.yml which defines the menu items.
2. Rewrite the Menu.php to use recursive funtion to build menu from menu.yml
OFJ-1747 Remove data/index directory

Remove data/index since it is useless now
OFJ-1543 Refactor Fisma_Menu to make it testable

1. Add the unit test script for menu
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Fix several bugs with IE such as frame border and image border.
Clean up the codes
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Combine all features to one config file
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix a bug that IE uses different iframe parameter when create iframe element.
2. Add the sample files for testing.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Merge master and resolve the conflicts.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add the configure file for the new features.
Testless build
OFT › SNIFF › #331 1 week ago
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1808 Add POC column to Finding Injection Template

1. Add a column to finding upload template.
2. Add the codes to set pocId to finding.
Testless build
OFT › PHPDOC › #429 1 week ago
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1808 Add POC column to Finding Injection Template

1. Add a column to finding upload template.
2. Add the codes to set pocId to finding.
Testless build
OFT › JSL › #646 1 week ago
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1808 Add POC column to Finding Injection Template

1. Add a column to finding upload template.
2. Add the codes to set pocId to finding.
55 passed
OFT › SCHEMA › #455 1 week ago
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1808 Add POC column to Finding Injection Template

1. Add a column to finding upload template.
2. Add the codes to set pocId to finding.
Testless build
OFT › TRUNK › #1016 2 weeks ago
OFJ-1804 Finding Evidence Upload File Size Out Of Sync With System Configuration

1. Fix logic bug in RemediationController.php.
2. Remove MAX_FILE_SIZE in upload-form.phtml
OFJ-1808 Add POC column to Finding Injection Template

1. Add a column to finding upload template.
2. Add the codes to set pocId to finding.
Testless build
OFT › PHPDOC › #425 2 weeks ago
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix the image loader bug on the first page of the panel.
2. Make panel background white.
3. Fix the text problem at the bottom left.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Do not concate WhatsNew.css into combined.css
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Move the javascript codes in WhatsNew layout to Fisma.WhatsNew
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Delete sample files.
2. Add some exceptions to WhatsNewController.php
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Fix several bugs with IE such as frame border and image border.
Clean up the codes
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Merge master and resolve the conflicts.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add whats-new.phtml layout.
Add WhatsNewController.php to get all the config files of new features and use whats-new layout to render.
Add index.phtml which is the template of whatsnew page.
Add showWhatsNewDialog() function to popup a new panel containing an iframe where what's page shows.
Add codes to call Fisma.Util.showWhatsNewDialog() in application/modules/default/views/scripts/dashboard/index.phtml.
Add jquery-localscroll.js plugin to public/javascripts/ folder.
Add jquery-scrollTo.js plugin to public/javascripts/ folder.
Add jquery-serialScroll.js plugin to public/javascripts/ folder.
Add whatsNew.css to public/stylesheets/ folder.
Add 'What's new' menu item under "user preference" menu.
Add codes to DashboardController.php to check whether it should show whatsnew panel.
Add swfobject.js for playing youtube video.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Remove window format of carriage return.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Remove the codes to get current version from foot. Use DashboardController.php to pass current version instead.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add the configure file for the new features.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Combine all features to one config file
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix a bug that IE uses different iframe parameter when create iframe element.
2. Add the sample files for testing.
Testless build
OFT › SNIFF › #327 2 weeks ago
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix the image loader bug on the first page of the panel.
2. Make panel background white.
3. Fix the text problem at the bottom left.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Do not concate WhatsNew.css into combined.css
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Move the javascript codes in WhatsNew layout to Fisma.WhatsNew
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Delete sample files.
2. Add some exceptions to WhatsNewController.php
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Fix several bugs with IE such as frame border and image border.
Clean up the codes
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Merge master and resolve the conflicts.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add whats-new.phtml layout.
Add WhatsNewController.php to get all the config files of new features and use whats-new layout to render.
Add index.phtml which is the template of whatsnew page.
Add showWhatsNewDialog() function to popup a new panel containing an iframe where what's page shows.
Add codes to call Fisma.Util.showWhatsNewDialog() in application/modules/default/views/scripts/dashboard/index.phtml.
Add jquery-localscroll.js plugin to public/javascripts/ folder.
Add jquery-scrollTo.js plugin to public/javascripts/ folder.
Add jquery-serialScroll.js plugin to public/javascripts/ folder.
Add whatsNew.css to public/stylesheets/ folder.
Add 'What's new' menu item under "user preference" menu.
Add codes to DashboardController.php to check whether it should show whatsnew panel.
Add swfobject.js for playing youtube video.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Remove window format of carriage return.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Remove the codes to get current version from foot. Use DashboardController.php to pass current version instead.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add the configure file for the new features.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Combine all features to one config file
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix a bug that IE uses different iframe parameter when create iframe element.
2. Add the sample files for testing.
Testless build
OFT › JSL › #642 2 weeks ago
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix the image loader bug on the first page of the panel.
2. Make panel background white.
3. Fix the text problem at the bottom left.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Do not concate WhatsNew.css into combined.css
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Move the javascript codes in WhatsNew layout to Fisma.WhatsNew
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Delete sample files.
2. Add some exceptions to WhatsNewController.php
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Fix several bugs with IE such as frame border and image border.
Clean up the codes
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Merge master and resolve the conflicts.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add whats-new.phtml layout.
Add WhatsNewController.php to get all the config files of new features and use whats-new layout to render.
Add index.phtml which is the template of whatsnew page.
Add showWhatsNewDialog() function to popup a new panel containing an iframe where what's page shows.
Add codes to call Fisma.Util.showWhatsNewDialog() in application/modules/default/views/scripts/dashboard/index.phtml.
Add jquery-localscroll.js plugin to public/javascripts/ folder.
Add jquery-scrollTo.js plugin to public/javascripts/ folder.
Add jquery-serialScroll.js plugin to public/javascripts/ folder.
Add whatsNew.css to public/stylesheets/ folder.
Add 'What's new' menu item under "user preference" menu.
Add codes to DashboardController.php to check whether it should show whatsnew panel.
Add swfobject.js for playing youtube video.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Remove window format of carriage return.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Remove the codes to get current version from foot. Use DashboardController.php to pass current version instead.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add the configure file for the new features.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Combine all features to one config file
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix a bug that IE uses different iframe parameter when create iframe element.
2. Add the sample files for testing.
1 of 55 failed
Build Completed Code Changes Tests
OFT › JSL › #642 2 weeks ago
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix the image loader bug on the first page of the panel.
2. Make panel background white.
3. Fix the text problem at the bottom left.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Do not concate WhatsNew.css into combined.css
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Move the javascript codes in WhatsNew layout to Fisma.WhatsNew
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Delete sample files.
2. Add some exceptions to WhatsNewController.php
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Fix several bugs with IE such as frame border and image border.
Clean up the codes
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Merge master and resolve the conflicts.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add whats-new.phtml layout.
Add WhatsNewController.php to get all the config files of new features and use whats-new layout to render.
Add index.phtml which is the template of whatsnew page.
Add showWhatsNewDialog() function to popup a new panel containing an iframe where what's page shows.
Add codes to call Fisma.Util.showWhatsNewDialog() in application/modules/default/views/scripts/dashboard/index.phtml.
Add jquery-localscroll.js plugin to public/javascripts/ folder.
Add jquery-scrollTo.js plugin to public/javascripts/ folder.
Add jquery-serialScroll.js plugin to public/javascripts/ folder.
Add whatsNew.css to public/stylesheets/ folder.
Add 'What's new' menu item under "user preference" menu.
Add codes to DashboardController.php to check whether it should show whatsnew panel.
Add swfobject.js for playing youtube video.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Remove window format of carriage return.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Remove the codes to get current version from foot. Use DashboardController.php to pass current version instead.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

Add the configure file for the new features.
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Combine all features to one config file
OFJ-1712 As a user I should be notified of whats new and be given helpful messages and videos so I can quickly get up to speed

1. Fix a bug that IE uses different iframe parameter when create iframe element.
2. Add the sample files for testing.
1 of 55 failed
TEST › TEST3 › #10 3 months ago
OFJ-1555 FZCAO: Combine view and edit screens into a single screen

1. Delete editAction() and _editObject(), and move the logics in _editObject() to _viewObject().
2. Delete getEditLinks() and object/edit.phtml
OFJ-1329 Add user groups support to Organizations

Add searching organization/system nickname to autocomplete form
OFJ-1644 Poor error message shows on the user create page when Click Check Account button

Initialize the variables at the beginning of the try block
OFJ-1555 FZCAO: Combine view and edit screens into a single screen

1. Add the codes to the _viewObject() so that it sets the form's action attribute when it has 'update' privilege, otherwise, set the form's readOnly to true.
2. Remove view or edit link
OFJ-1611 Spinner image keep loading in Systems Aggregation View page when there is no system

Show the error message gracefully when there is no organizations
OFJ-1329 Add user groups support to Organizations

Fix a bug which causes allowed memory exhausted error sometimes when assess user tabview repeatedly.
OFJ-1594 Poor error message shows on finding summary page when test without any organization

It should show No Data Available if there is no organization
OFJ-1618 An error occurs on Findings=>reports=>Plug-in reports page under product mode

Change the unit test accordingly
OFJ-1612 The tree structure shows different between Point Of Contact hierarchy view page and finding summary page

Add the codes to move the node to its nearest ancestor with organization type if its parent is a system
OFJ-1629 Add host_url configuration interface and remove HTTP_HOST from Fisma_Url

1. Add host_url to general config form and change Fisma_Url::baseUrl() to use host_url.
2. Change the unit tests accordingly.
OFJ-1618 An error occurs on Findings=>reports=>Plug-in reports page under product mode

Replace ->_me_id with  which is passed by function parameter.
OFJ-1329 Add user groups support to Organizations

1. Add two new files of organization.phtml and view.phtml
2. Use tabview when view organization.
OFJ-131 ACL for some finding fields is only checked in the UI, not verified in the controller

1. Move ACL and status checking from view script to controller.
2. Add Meta data of ACL and status to finding.yml.
OFJ-1603 User cannot login when the content of "Warning Banner" length is too long

Remove fixedcenter config which forces the panel to stay at the page center, use center() instead.
OFJ-1611 Spinner image keep loading in Systems Aggregation View page when there is no system

Fix an issue that the disposal systems still show after uncheck the Display Disposal Systems checkbox when the system contains only disposal system.
OFJ-1629 Add host_url configuration interface and remove HTTP_HOST from Fisma_Url

1. Add a Fisma_Zend_Form_Validate_Url class and an unit test class accordly.
2. Add the validate above to host_url form field.
3. Add a tooltip to the host_url form field.
OFJ-1329 Add user groups support to Organizations

1. Fix several coding styles
OFJ-1611 Spinner image keep loading in Systems Aggregation View page when there is no system

Submit minified javascript
OFJ-1623 "&amp;" shows on the create new user page and change password page

Remove htmlentities() so that it is escaped only at view page
Testless build
OFT › PHPDOC › #267 5 months ago
OFJ-1601 A XSS vulnerability found when a new user login after change the system name to "<script type=text/javascript>alert('XSS FAIL');</script>"

Add the code to escape the system name
Testless build
OFT › SCHEMA › #294 5 months ago
OFJ-1601 A XSS vulnerability found when a new user login after change the system name to "<script type=text/javascript>alert('XSS FAIL');</script>"

Add the code to escape the system name
Testless build
Build Completed Code Changes Tests
TEST › TEST2 › #2 3 months ago
OFJ-1675 Plug-in Reports data miss when login with sample user

Add ->id to the first parameter when calls Doctrine::getTable('User')->getRolesQuery() in application/models/User.php.
OFJ-1659 Labels of "High, Moderate and Low" are missing on the charts until refresh the page when apply settings

Set the top legend's style display to block when create the top legend
OFJ-1672 Fix Warning Message

Remove redundant codes
OFJ-1647 Persist the closure of message boxes

Move the codes of generating last login messages from the dashboard action to the auth action.
OFJ-1629 Add host_url configuration interface and remove HTTP_HOST from Fisma_Url

1. Add a Fisma_Zend_Form_Validate_Url class and an unit test class accordly.
2. Add the validate above to host_url form field.
3. Add a tooltip to the host_url form field.
OFJ-1698 As a user I don't want to see success messages when I log in successfully but I do want to see error messages when a failed login has occured

Change the function to get only failed login attempt message.
OFJ-1569 The user tab view of system view page looks different between IE7 and Firefox

Add css code to override margin of dl to 0 in ie7 and ie9 hacks css files
OFJ-1680 An error shows on the php.log after switch filter on finding summary page

Make the csrf token available when post data from the sync() in the PersistentStorage.js
OFJ-1672 Fix Warning Message

Replace the warning messages related to finding mitigation strategy actions.
Testless build

Powered by a free Atlassian Bamboo open source license for OpenFISMA. Try Bamboo - The Zen of Continuous Integration.